[From nobody Sun Feb 22 20:07:57 2004
To: Darin Willits <darin@blueyonder.co.uk>
References: <1063753519.6123.34.camel@wizzard.willits.ca>
From: Derek Atkins <warlord@MIT.EDU>
Date: Mon, 08 Dec 2003 20:25:13 -0500
Subject: Re: budgeting -initial patch
MIME-Version: 1.0

Hi,

I'm VERY, VERY sorry I'm only starting to look at this now.  Mea
Culpa.  Let me say that so far it looks pretty good.  I'm only sorry
that I dropped the ball on this (and apparantly so did everyone else).

Anyways, I've got a couple style comments and a request.  First, can
you name your data types with a Gnc?  E.g. GncBudget,
GncBudgetCategory, etc?  It makes it a lot easier when dealing with
other packages.  Second, could you name your files gnc* as well (at
least the files in src/engine)?  Granted this might cause a filename
conflict between engine/gnc-budget and gnome/gnc-budget -- I'll leave
it to you do deal appropriately.

Also, the request: Can you update your patch to the current code in
CVS and, in the process, update your code to use the qofinstance
object "class"?

Finally, one question: what/why did you change (in) commodity.glade?
I thought we already had the commodity selector dialog in CVS?

Anyways, I promise to be more timely on the next round.  It looks
really good so far (from a cusory examination).

Thanks for your contribution!

-derek

]